refactor(amber): rename Controller to Coordinator#6124
Open
Yicong-Huang wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
engine
pyamber
refactor
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6124 +/- ##
============================================
+ Coverage 59.14% 59.15% +0.01%
- Complexity 3201 3206 +5
============================================
Files 1132 1132
Lines 43681 43681
Branches 4734 4734
============================================
+ Hits 25833 25838 +5
+ Misses 16416 16406 -10
- Partials 1432 1437 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 437 | 0.267 | 21,646/33,055/33,055 us | 🟢 -31.9% / 🔴 +118.3% |
| 🔴 | bs=100 sw=10 sl=64 | 941 | 0.574 | 107,432/127,751/127,751 us | 🔴 +16.8% / 🔴 +18.4% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,097 | 0.67 | 918,679/951,694/951,694 us | ⚪ within ±5% / 🟢 -10.2% |
Baseline details
Latest main 3a12e62 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 437 tuples/sec | 435 tuples/sec | 776.36 tuples/sec | +0.5% | -43.7% |
| bs=10 sw=10 sl=64 | MB/s | 0.267 MB/s | 0.265 MB/s | 0.474 MB/s | +0.8% | -43.7% |
| bs=10 sw=10 sl=64 | p50 | 21,646 us | 19,702 us | 12,636 us | +9.9% | +71.3% |
| bs=10 sw=10 sl=64 | p95 | 33,055 us | 48,567 us | 15,143 us | -31.9% | +118.3% |
| bs=10 sw=10 sl=64 | p99 | 33,055 us | 48,567 us | 18,954 us | -31.9% | +74.4% |
| bs=100 sw=10 sl=64 | throughput | 941 tuples/sec | 1,000 tuples/sec | 985.33 tuples/sec | -5.9% | -4.5% |
| bs=100 sw=10 sl=64 | MB/s | 0.574 MB/s | 0.611 MB/s | 0.601 MB/s | -6.1% | -4.6% |
| bs=100 sw=10 sl=64 | p50 | 107,432 us | 100,824 us | 101,671 us | +6.6% | +5.7% |
| bs=100 sw=10 sl=64 | p95 | 127,751 us | 109,395 us | 107,939 us | +16.8% | +18.4% |
| bs=100 sw=10 sl=64 | p99 | 127,751 us | 109,395 us | 113,798 us | +16.8% | +12.3% |
| bs=1000 sw=10 sl=64 | throughput | 1,097 tuples/sec | 1,097 tuples/sec | 1,016 tuples/sec | 0.0% | +7.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.67 MB/s | 0.669 MB/s | 0.62 MB/s | +0.1% | +8.0% |
| bs=1000 sw=10 sl=64 | p50 | 918,679 us | 903,975 us | 989,693 us | +1.6% | -7.2% |
| bs=1000 sw=10 sl=64 | p95 | 951,694 us | 967,238 us | 1,028,327 us | -1.6% | -7.5% |
| bs=1000 sw=10 sl=64 | p99 | 951,694 us | 967,238 us | 1,059,969 us | -1.6% | -10.2% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,457.92,200,128000,437,0.267,21645.61,33054.69,33054.69
1,100,10,64,20,2125.89,2000,1280000,941,0.574,107431.90,127751.42,127751.42
2,1000,10,64,20,18228.00,20000,12800000,1097,0.670,918678.55,951694.18,951694.18
Yicong-Huang
force-pushed
the
refactor/controller-to-coordinator
branch
2 times, most recently
from
743ac96 to
47154ff
Compare
Yicong-Huang
force-pushed
the
refactor/controller-to-coordinator
branch
from
47154ff to
63ef84c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Renames Amber’s master actor concept from Controller to Coordinator across the engine stack (Scala runtime, RPC/protobuf surface, and Python runtime/tests) to better reflect the actor’s coordinating role and align naming with prior scheduler renames.
Changes:
- Renamed Scala packages/types/constants and their call sites (runtime + tests) from
Controller*/CONTROLLER/PreferControllertoCoordinator*/COORDINATOR/PreferCoordinator. - Renamed gRPC proto surface from
ControllerService/ControllerInitiateQueryStatisticstoCoordinatorService/CoordinatorInitiateQueryStatisticsand updated Scala/Python usage. - Updated Python runtime stub naming (
controller_*→coordinator_*) and test expectations accordingly.
Reviewed changes
Copilot reviewed 121 out of 121 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| common/workflow-operator/src/test/scala/org/apache/texera/amber/operator/SpecialPhysicalOpFactorySpec.scala | Update location preference symbol to PreferCoordinator in operator spec. |
| common/workflow-core/src/test/scala/org/apache/texera/service/util/LargeBinaryManagerSpec.scala | Update test comment terminology from controller → coordinator. |
| common/workflow-core/src/test/scala/org/apache/texera/amber/util/VirtualIdentityUtilsSpec.scala | Update special-actor identity tests to use COORDINATOR. |
| common/workflow-core/src/test/scala/org/apache/texera/amber/core/workflow/WorkflowCoreTypesSpec.scala | Update LocationPreference subtype assertions to PreferCoordinator. |
| common/workflow-core/src/test/scala/org/apache/texera/amber/core/workflow/PhysicalOpSpec.scala | Update factory behavior expectations to prefer coordinator. |
| common/workflow-core/src/main/scala/org/apache/texera/amber/util/VirtualIdentityUtils.scala | Update comments for special actor ids (SELF/COORDINATOR). |
| common/workflow-core/src/main/scala/org/apache/texera/amber/core/workflow/PhysicalOp.scala | Default locationPreference changed to PreferCoordinator and docs updated. |
| common/workflow-core/src/main/scala/org/apache/texera/amber/core/workflow/LocationPreference.scala | Rename PreferController singleton to PreferCoordinator and update docs. |
| amber/src/test/scala/org/apache/texera/web/service/WorkflowExecutionServiceSpec.scala | Update scaladoc variable naming to coordinatorConfig. |
| amber/src/test/scala/org/apache/texera/amber/error/ErrorUtilsSpec.scala | Update dummy-actor fallback test to COORDINATOR. |
| amber/src/test/scala/org/apache/texera/amber/engine/faulttolerance/ReplaySpec.scala | Update control channel identities and contexts to COORDINATOR. |
| amber/src/test/scala/org/apache/texera/amber/engine/faulttolerance/LoggingSpec.scala | Update RPC method imports and control identities to coordinator service. |
| amber/src/test/scala/org/apache/texera/amber/engine/faulttolerance/CheckpointSpec.scala | Update processor/config types to Coordinator* in checkpoint tests. |
| amber/src/test/scala/org/apache/texera/amber/engine/e2e/TestUtils.scala | Update client interface accessors (coordinatorInterface) and config types. |
| amber/src/test/scala/org/apache/texera/amber/engine/e2e/PauseSpec.scala | Update config/imports and client interface calls to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/e2e/DataProcessingSpec.scala | Update package import from controller → coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/e2e/BatchSizePropagationSpec.scala | Update scheduler construction and identity constant to COORDINATOR. |
| amber/src/test/scala/org/apache/texera/amber/engine/common/CheckpointSubsystemSpec.scala | Update test comment references from ControllerSpec → CoordinatorSpec. |
| amber/src/test/scala/org/apache/texera/amber/engine/common/ambermessage/AmberMessageEnvelopesSpec.scala | Update test comment references from ControllerSpec → CoordinatorSpec. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/WorkerSpec.scala | Update control message channel/context identities to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/promisehandlers/EndHandlerSpec.scala | Update control identity and comment wording to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/managers/SerializationManagerSpec.scala | Rename non-worker actor id variable to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/managers/OutputPortStorageWriterThreadSpec.scala | Update comment describing error propagation path to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/worker/DataProcessorSpec.scala | Update control message channel/context identities to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/WorkflowExecutionManagerSpec.scala | Update harness/probe/config naming to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionManagerTestSupport.scala | Rename harness/probe types and internal identities to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionManagerSpec.scala | Update probes/harness/config and control channels to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/DefaultCostEstimatorSpec.scala | Update identity constant passed into cost estimator to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/scheduling/CostBasedScheduleGeneratorSpec.scala | Update identity constant passed into schedule generator to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/pythonworker/PythonWorkflowWorkerSpec.scala | Update commented-out test references to COORDINATOR. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/logreplay/LogreplayPrimitivesSpec.scala | Update documentation references to Coordinator.scala. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/deploysemantics/AddressInfoSpec.scala | Update API expectations for coordinatorAddress rename. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/WorkflowSchedulerSpec.scala | Update package and identity constant usage to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/GlobalReplayManagerSpec.scala | Update package from controller → coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/WorkflowExecutionSpec.scala | Update package from controller.execution → coordinator.execution. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/WorkerPortExecutionSpec.scala | Update package from controller.execution → coordinator.execution. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/RegionExecutionSpec.scala | Update package and comment wording to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/OperatorExecutionSpec.scala | Update package and imports to coordinator.execution. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/LinkExecutionSpec.scala | Update package to coordinator.execution. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/ExecutionUtilsSpec.scala | Update package to coordinator.execution. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/CoordinatorSpec.scala | New coordinator-named spec file (renamed from controller). |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/coordinator/ClientEventSpec.scala | Update package to coordinator. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/controller/ControllerSpec.scala | Remove old controller-named spec file. |
| amber/src/test/scala/org/apache/texera/amber/engine/architecture/control/TrivialControlSpec.scala | Update special identity mapping to COORDINATOR. |
| amber/src/test/python/pytexera/storage/test_large_binary_manager.py | Update comments to coordinator terminology. |
| amber/src/test/python/core/util/test_virtual_identity.py | Update special-actor expectations to COORDINATOR. |
| amber/src/test/python/core/runnables/test_main_loop.py | Update identities and assertion messages to coordinator wording. |
| amber/src/test/python/core/runnables/test_data_processor.py | Update error-path comment to coordinator terminology. |
| amber/src/test/python/core/runnables/test_console_message.py | Rename fixture/channel to coordinator and update references. |
| amber/src/test/python/core/architecture/rpc/test_async_rpc_client.py | Update stub type/name and client accessor to coordinator_stub(). |
| amber/src/test/integration/org/apache/texera/amber/engine/e2e/ReconfigurationIntegrationSpec.scala | Update config and client interface calls to coordinator. |
| amber/src/main/scala/org/apache/texera/workflow/WorkflowCompiler.scala | Update Workflow import package to coordinator. |
| amber/src/main/scala/org/apache/texera/web/service/WorkflowService.scala | Update engine config type and variable naming to coordinator. |
| amber/src/main/scala/org/apache/texera/web/service/WorkflowExecutionService.scala | Update constructor/config param and interface calls to coordinator. |
| amber/src/main/scala/org/apache/texera/web/service/ExecutionStatsService.scala | Update imports to coordinator package. |
| amber/src/main/scala/org/apache/texera/web/service/ExecutionRuntimeService.scala | Update interface calls (pause/resume/checkpoint) to coordinator. |
| amber/src/main/scala/org/apache/texera/web/service/ExecutionResultService.scala | Update imports to coordinator package. |
| amber/src/main/scala/org/apache/texera/web/service/ExecutionReconfigurationService.scala | Update dispatch path to coordinator interface and imports. |
| amber/src/main/scala/org/apache/texera/web/service/ExecutionConsoleService.scala | Update debug/eval interface calls to coordinator. |
| amber/src/main/scala/org/apache/texera/web/resource/MockKillWorkerResource.scala | Update commented variable naming to coordinator. |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowExecutionsResource.scala | Update replay-log reader key from CONTROLLER to COORDINATOR. |
| amber/src/main/scala/org/apache/texera/web/ComputingUnitMaster.scala | Update engine config type to CoordinatorConfig. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/virtualidentity/util.scala | Rename CONTROLLER constant to COORDINATOR. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/rpc/AsyncRPCHandlerInitializer.scala | Update handler imports/types to coordinator service; rename interface accessor. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/rpc/AsyncRPCClient.scala | Rename controllerInterface proxy to coordinatorInterface. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/client/ClientActor.scala | Instantiate Coordinator actor and route control invocations to it. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/client/AmberClient.scala | Expose coordinatorInterface proxy and accept CoordinatorConfig. |
| amber/src/main/scala/org/apache/texera/amber/engine/common/ambermessage/RecoveryPayload.scala | Update comments to coordinator terminology. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/WorkflowWorker.scala | Update imports to coordinator types (e.g. ReplayStatusUpdate). |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/promisehandlers/EndHandler.scala | Update doc wording to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/managers/OutputPortStorageWriterThread.scala | Update comments to coordinator terminology. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/DPThread.scala | Update large-binary base-URI comment to coordinator naming. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/worker/DataProcessor.scala | Send worker events (port/state/completion/console) via coordinatorInterface. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/WorkflowExecutionManager.scala | Rename config type/param to CoordinatorConfig. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/RegionExecutionManager.scala | Rename config type/param and coordinator actorId constant usage. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/scheduling/config/WorkerConfig.scala | Update large-binary base-URI comment to coordinator naming. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/messaginglayer/OutputManager.scala | Update comment to coordinator terminology. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/deploysemantics/layer/WorkerExecution.scala | Update import package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/deploysemantics/AddressInfo.scala | Rename controllerAddress field to coordinatorAddress and docs. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/WorkflowScheduler.scala | Update package name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/Workflow.scala | Update package name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/WorkerStateUpdatedHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/WorkerExecutionCompletedHandler.scala | Update RPC call name and timer-service field to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/TakeGlobalCheckpointHandler.scala | Update package/self-type and interface name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/StartWorkflowHandler.scala | Update package/self-type and timer-service field to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/RetryWorkflowHandler.scala | Update package/self-type and identity constant to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/RetrieveWorkflowStateHandler.scala | Update package/self-type and interface name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/ResumeHandler.scala | Update package/self-type and timer-service field to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/ReconfigurationHandler.scala | Update package/self-type and control-channel identities to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/QueryWorkerStatisticsHandler.scala | Rename handler entrypoint to coordinatorInitiateQueryStatistics. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/PortCompletedHandler.scala | Update interface/method names and identity constant to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/PauseHandler.scala | Update package/self-type and timer-service field to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/LinkWorkersHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/JumpToOperatorRegionHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/EvaluatePythonExpressionHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/EmbeddedControlMessageHandler.scala | Update package/self-type and control-channel identities to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/DebugCommandHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/promisehandlers/ConsoleMessageHandler.scala | Update package/self-type to coordinator initializer. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/GlobalReplayManager.scala | Update package name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/WorkflowExecution.scala | Update package/imports to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/WorkerPortExecution.scala | Update package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/RegionExecution.scala | Update package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/OperatorExecution.scala | Update package/imports to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/LinkExecution.scala | Update package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/ExecutionUtils.scala | Update package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/execution/ChannelExecution.scala | Update package to coordinator.execution. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/CoordinatorTimerService.scala | Rename timer service class and method constant to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/CoordinatorProcessor.scala | Rename processor class/fields to coordinator naming. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/CoordinatorAsyncRPCHandlerInitializer.scala | Rename handler initializer and gRPC service trait to coordinator service. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/Coordinator.scala | Rename controller actor/config to coordinator and update identity constant. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/coordinator/ClientEvent.scala | Update package name to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/PekkoActorRefMappingService.scala | Update propagation stop condition and comments to coordinator. |
| amber/src/main/scala/org/apache/texera/amber/engine/architecture/common/ExecutorDeployment.scala | Use PreferCoordinator and coordinatorAddress for placement decisions. |
| amber/src/main/python/pytexera/storage/large_binary_manager.py | Update docstrings to coordinator terminology. |
| amber/src/main/python/core/runnables/main_loop.py | Switch to coordinator_stub() for completion/port/console RPCs. |
| amber/src/main/python/core/runnables/data_processor.py | Update exception-path comment to coordinator terminology. |
| amber/src/main/python/core/architecture/rpc/async_rpc_client.py | Rename controller stub to coordinator stub and update default receiver identity. |
| amber/src/main/python/core/architecture/handlers/control/end_worker_handler.py | Update handler docstring to coordinator terminology. |
| amber/src/main/protobuf/org/apache/texera/amber/engine/architecture/rpc/coordinatorservice.proto | Rename service and RPC to coordinator equivalents. |
| amber/src/main/protobuf/org/apache/texera/amber/engine/architecture/rpc/controlreturns.proto | Update comment label from controller responses → coordinator responses. |
| amber/src/main/protobuf/org/apache/texera/amber/engine/architecture/rpc/controlcommands.proto | Update comment labels and scalapb extends to coordinator ClientEvent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Yicong-Huang
force-pushed
the
refactor/controller-to-coordinator
branch
from
63ef84c to
38da6a2
Compare
aglinxinyuan
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Renames the Amber master actor from Controller to Coordinator across the whole engine — classes, variables, comments, protobuf, and tests:
architecture.controller→architecture.coordinator(dirs moved withgit mv)Controller→Coordinator,ControllerProcessor→CoordinatorProcessor,ControllerConfig→CoordinatorConfig,ControllerAsyncRPCHandlerInitializer,ControllerTimerService,ControllerSpec→Coordinator*controllerservice.proto→coordinatorservice.proto;service ControllerService→CoordinatorService; rpcControllerInitiateQueryStatistics→CoordinatorInitiateQueryStatistics; scalapbextendsoption and proto commentscontroller_interface/_controller_service_stub/controller_stub→coordinator_*; generated betterproto bindings are gitignored and regenerate from the renamed proto (bin/python-proto-gen.shverified)CONTROLLERActorVirtualIdentity constant →COORDINATOR(Scala + Python)PreferController→PreferCoordinator(workflow-core)controllerConfig,controllerTimerService,controllerAddress, …) and prose in scaladoc/docstringsThe rename is purely mechanical (case-preserving substring replacement, verified exhaustively):
grep -ri controlleroveramber/andcommon/returns zero matches afterwards. Untouched on purpose: Angular'sHttpTestingController, the WebAbortControllerin agent-service, and Envoy'sgatewayclass-controllerin the k8s templates.Follows #6123 (merged), which freed the Coordinator name by renaming the region-scheduling coordinators to managers.
Any related issues, documentation, discussions?
Closes #6122.
How was this PR tested?
Refactor with no behavior change — existing tests stay green with no assertion edits:
Full
Test/compileofWorkflowCore,WorkflowOperator, andWorkflowExecutionServicepasses; Python bindings regenerated viabin/python-proto-gen.shand 68 pytest cases pass.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)